Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Completion array anyOf #390

Merged
merged 4 commits into from
Jan 15, 2021
Merged

fix: Completion array anyOf #390

merged 4 commits into from
Jan 15, 2021

Conversation

p-spacek
Copy link
Contributor

When object is array anyOf completion doesn't suggest - (array item)

test_array_anyOf_2objects:
  - obj1:
      name: 5  
  # not ok when type is anyOf

What does this PR do?

This PR implement array completion on array anyOf type
image

What issues does this PR fix or reference?

Partly: p-spacek#5

Is it tested? How?

unit test

@coveralls
Copy link

coveralls commented Jan 12, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 81.3% when pulling 252c1e8 on p-spacek:fix/completion-array into b988f32 on redhat-developer:master.

evidolob
evidolob reviewed Jan 13, 2021
View reviewed changes
test/fixtures/testArrayCompletionSchema.json Outdated Show resolved Hide resolved
test/autoCompletion.test.ts Outdated Show resolved Hide resolved
JPinkney
JPinkney approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played around with it a bit and it LGTM. I did find a different but unrelated issue to this PR though when testing
testyaml

obj1 and obj2 when autocompleting don't seem to indent correctly

@JPinkney JPinkney merged commit 80a34d4 into redhat-developer:master Jan 15, 2021
@p-spacek p-spacek deleted the fix/completion-array branch January 20, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evidolob evidolob evidolob approved these changes

@JPinkney JPinkney JPinkney approved these changes

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@p-spacek @coveralls @evidolob @joshuawilson @JPinkney