-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multiple schema deletions #397
feat: add multiple schema deletions #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, my only suggestion would be to change deleteWhole to deleteAll or something like that
agree, had deleteAll before, but I overthink it... |
@p-spacek Can you update this PR? I'm going to merge it after. |
Sorry I didn't notice. |
@p-spacek No problem. Thank you, for your contribution! |
What does this PR do?
add schema modification to delete schemas from cache.
Motivation:
when dynamically changing shared schema, I use this deleteWhole schema action to delete old parent schemas from cache. So language server will reload parents schemas with updated referenced schema.
What issues does this PR fix or reference?
no ref
Is it tested? How?
added unit test