Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix services initialization #399

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

evidolob
Copy link
Collaborator

What does this PR do?

Fixes services initialization, before we create two instances of LanguageService first with default client capabilities (for tests setup) and second when we receive real client capabilities, the problem in first as it was used to handle all requests from client. In that case we not handle client capabilities at all.

What issues does this PR fix or reference?

Found during work on #395

Is it tested? How?

Just run yaml-ls with this PR changes, you should not see any differences in LS behaviour

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob self-assigned this Jan 26, 2021
@coveralls
Copy link

coveralls commented Jan 26, 2021

Coverage Status

Coverage increased (+0.4%) to 76.568% when pulling 070919d on evidolob:fix-inialization into d35e49a on redhat-developer:master.

@evidolob evidolob merged commit 39b111e into redhat-developer:master Jan 27, 2021
@evidolob evidolob deleted the fix-inialization branch January 27, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants