feat: multiple schema distinction in validation #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
requested review from
evidolob,
joshuawilson and
JPinkney
as code owners
evidolob
reviewed
Feb 23, 2021
- add new end line - modify warning message consts
|
Thank you for really quick review and merge!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When there are more possible warning messages from different schemas or objects connected to specific problem, validator takes only the first one and it's hard to recognize the core of the problem.
before:
after:
before:
after:
after:
jump to multiple schemas:
before:
after:
What issues does this PR fix or reference?
p-spacek#10
Is it tested? How?
Unit tests