Add CodeAction to convert Tab characters to spaces #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
|
👍 |
JPinkney
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Just tried it out and everything was working for me! Just wondering if it also makes sense to have a code action with Convert all tabs to spaces so we don't have to do it multiple times. I assume if someone has tabs in their yaml file they probably just have a setting enabled that keeps tabs as tabs instead of tabs to spaces
Signed-off-by: Yevhen Vydolob <[email protected]>
|
@JPinkney I added |
JPinkney
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds various things:
Using tabs can lead to unpredictable resultsdiagnostic in to one, previously we report each tab character separatelyDemo:
Screen.Recording.2021-02-25.at.12.16.37.mov
Convert all tabs to spaces:
Screen.Recording.2021-02-25.at.17.08.27.mov
What issues does this PR fix or reference?
Fix: #244
Is it tested? How?
With new tests and manually, just create yaml file with tab's characters and see that
Using tabs can lead to unpredictable resultserror has CodeActionConvert Tab to Spacesand when it executed tabs replaced with spaces according to current editor settings.