Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in hover and codelens #534

Merged

Conversation

evidolob
Copy link
Collaborator

@evidolob evidolob commented Aug 25, 2021

What does this PR do?

It fix possible issue in recursivelyBuildAst which can cause redhat-developer/vscode-yaml#583 and redhat-developer/vscode-yaml#584

Also this PR enhance error handling in hover and codelens implementations.

What issues does this PR fix or reference?

Fix redhat-developer/vscode-yaml#583
Fix redhat-developer/vscode-yaml#584

Is it tested? How?

No, as currently telemetry doesn't have enough information about errors.

@evidolob evidolob self-assigned this Aug 25, 2021
@coveralls
Copy link

coveralls commented Aug 25, 2021

Coverage Status

Coverage decreased (-0.2%) to 78.327% when pulling ac131cb on evidolob:fix-error-handling-in-hover-codelens into 0b96882 on redhat-developer:main.

Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evidolob evidolob merged commit 40b6fe4 into redhat-developer:main Sep 13, 2021
@evidolob evidolob deleted the fix-error-handling-in-hover-codelens branch September 13, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants