Add methods which allow client get schemas info #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
…er into new-schema-selection Signed-off-by: Yevhen Vydolob <[email protected]>
gorkem
suggested changes
Nov 21, 2021
| name: 'Schema name', | ||
| description: 'Schema description', | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Should it also have a test for the case where there are no schemas associated.
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
…er into new-schema-selection Signed-off-by: Yevhen Vydolob <[email protected]>
gorkem
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It add LSP methods which allow Client get information about all know schemas and schemas used to validate current file.
That methods allows to build UI for schema selection.
What issues does this PR fix or reference?
redhat-developer/vscode-yaml#565
Is it tested? How?
With tests