Fix links error reporting #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
JPinkney
reviewed
Nov 24, 2021
Signed-off-by: Yevhen Vydolob <[email protected]>
…er into fix-links-error Signed-off-by: Yevhen Vydolob <[email protected]>
JPinkney
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes telemetry error reporting for
linksfeature.Also it change sending errors to telemetry, as
JSON.stringify()return empty string forErrorWhat issues does this PR fix or reference?
None, we have a lot of
Request textDocument/documentLink failed. Message: Request textDocument/documentLink failed with message: Cannot read property 'sendError' of undefinedIs it tested? How?
manually