Improve telemetry errors #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
gorkem
suggested changes
Dec 11, 2021
There was a problem hiding this comment.
It is missing test cases. I have added some on evidolob#1 also handled a null check.
Added tests for convertErrorToTelemetryMsg and fixed the null case that was failing.
gorkem
approved these changes
Dec 14, 2021
JPinkney
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It ensures that we send errors to telemetry with stack traces.
Also it add
uncaughtExceptionerror handler for yaml-lsprocessto track errors and sand them with stack trace to telemetry. That should add possibility to detectMaximum call stack size exceedederrors.What issues does this PR fix or reference?
None, but it help with issues like redhat-developer/vscode-yaml#652 where we have only error message, but we don't have any trace.
Is it tested? How?
manually