feat: parent completion #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 30, 2021 23:39
evidolob
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the possibility to suggest and insert the whole object structure. So a user doesn't have to add required properties one by one.
Another advantage is when a user has to pick between a few 'anyOf' objects.
It also works with incomplete objects.
Display two possibilities (anyOf) of complex objects and insert the whole structure of all required props of the object.
Screen.Recording.2022-01-01.at.23.30.05.mov
Suggest the rest of the 'parent' object (missing required props).
Screen.Recording.2022-01-01.at.23.30.24.mov
Added also feature that adds const value instead of $1. So instead of
prop: {$1:value}is used prop: value. (beginning of the second video)What issues does this PR fix or reference?
no ref
Is it tested? How?
few unit tests