Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock [email protected] #637

Merged

Conversation

remcohaszing
Copy link
Contributor

What does this PR do?

This is a around #585 by locking vscode-json-languageservice to version 4.1.8.

It’s a workaround, not a desirable fix.

What issues does this PR fix or reference?

#585
microsoft/vscode-json-languageservice#123

Is it tested? How?

All steps are run from the project root using vim and the following configuration:

au User lsp_setup call lsp#register_server({
  \ 'name': 'yaml',
  \ 'cmd': {server_info->['node', 'out/server/src/server.js', '--stdio']},
  \ 'allowlist': ['yaml'],
\})

call plug#begin('~/.vim/plugged')

Plug 'prabirshrestha/vim-lsp'

call plug#end()

Clone and setup the project

git clone [email protected]:redhat-developer/yaml-language-server.git
yarn
yarn compile
yarn add [email protected]

Create a file named app-definition.yaml with the following content. Use vim to edit it.

name: 123

This correctly shows that name is invalid and some properties are missing.

Now close vim and run the following command:

Now when editing the same file again, it shows an error saying the JSON schema can’t be resolved.

Version 4.1.9 introduces a regression causing redhat-developer#585.
@coveralls
Copy link

coveralls commented Jan 7, 2022

Coverage Status

Coverage remained the same at 79.591% when pulling 296e13f on remcohaszing:lock-vscode-json-languageservice into af7d0c3 on redhat-developer:main.

Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gorkem gorkem merged commit 8109ffb into redhat-developer:main Jan 10, 2022
@remcohaszing remcohaszing deleted the lock-vscode-json-languageservice branch February 13, 2022 13:42
remcohaszing added a commit to remcohaszing/schemastore that referenced this pull request Mar 27, 2023
remcohaszing added a commit to remcohaszing/schemastore that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants