fix: completion in the middle of the empty text

[p-spacek]

What does this PR do?

fix completion when the cursor is in the middle of the empty text

compleion-in-the-middle-of-the-empty-text.mov

What issues does this PR fix or reference?

no ref

Is it tested? How?

added UT

[coveralls]

Coverage decreased (-0.05%) to 82.188% when pulling 7e3e98d on p-spacek:fix/completion-in-the-middle-of-the-empty-text into 9cfb0c7 on redhat-developer:main.

[gorkem]

LGTM

[gorkem]

Should this also work for boolean properties ?

[p-spacek]

Should this also work for boolean properties ?

Screen.Recording.2022-04-08.at.10.55.17.mov

it seems ok.

but there are probably more other similar problems with not vert valid YAML structure when users expect correct behaviour.
It's possible to fix one by one and add more and more conditions/fallbacks. But I thought that there could be also an approach to modify yaml before yamlCompletion.doComplete evaluates the result.
For example modify (temporary without modification of the original file)

• 'prop:' -> 'prop: ' then evaluation of the completion items
• '-' -> '- '
• 'prop: # ' -> 'prop: #' (#means cursor position)
• 'prop:      ' -> 'prop: '

and others.

so maybe next time, we can try the cleanup befo parsing of the yaml?

[gorkem]

Thanks for testing it.

[msivasubramaniaan]

@p-spacek it needs a rebase.