Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable eslint import checks #716

Merged
merged 1 commit into from
May 24, 2022
Merged

Enable eslint import checks #716

merged 1 commit into from
May 24, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 18, 2022 •
edited
Loading

  • Enable eslint plugin to check imports
  • Fix current problems identified
  • Add option to treat warnings as error so we avoid regressions
  • Add package-lock.json to exclude as current projects uses yarn

That was suggested on #593 (comment)

@ssbarnea ssbarnea requested a review from gorkem May 18, 2022 14:21
@coveralls
Copy link

coveralls commented May 18, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 82.379% when pulling 37d936f on ssbarnea:fix/imports into 417a68e on redhat-developer:main.

@ssbarnea ssbarnea marked this pull request as ready for review May 18, 2022 14:22
gorkem
gorkem approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msivasubramaniaan msivasubramaniaan merged commit c2e2e0f into redhat-developer:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem gorkem approved these changes

@msivasubramaniaan msivasubramaniaan msivasubramaniaan approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ssbarnea @coveralls @gorkem @msivasubramaniaan