Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My project uses
yaml-language-server
, and I got these errors in Sentry:Unfortunately, I wasn't able to reproduce this error, so all my work is just following the stacktrace.
What issues does this PR fix or reference?
The only place where the function
getLineCharCode
is used is here:yaml-language-server/src/languageservice/utils/indentationGuesser.ts
Lines 136 to 138 in eae5206
Both surrounding code and description on
charCodeAt
suggest that this index should be 0-based, but thegetLineCharCode
is written with a 1-based index in mind, which seems like the source of this bug.Is it tested? How?
I wasn't able to reproduce the original issue, so it's hard for me to test this fix.