Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper indenting of snippet within an array #745

Merged

Conversation

rickcowan
Copy link
Contributor

What does this PR do?

When choosing a snippet to auto-complete within an array, the indentation level was wrong on the lines below the insertion point.

example:
  - #cursor here

would auto-complete to:

example:
  - item1: "some item"
  item2: "another item"

rather than:

example:
  - item1: "some item"
    item2: "another item"

What issues does this PR fix or reference?

no ref

Is it tested? How?

Manual tests as well as new unit test.

@coveralls
Copy link

coveralls commented Jul 1, 2022

Coverage Status

Coverage increased (+0.003%) to 82.557% when pulling 422beb0 on jigx-com:fix/code-snippet-in-array into cd71414 on redhat-developer:main.

Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. There is a typo on the commit message "identing" instead of "indenting". You can optionally fix that.

@msivasubramaniaan msivasubramaniaan merged commit 99671d1 into redhat-developer:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants