-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anchor diagnostics #846
Fix anchor diagnostics #846
Conversation
86a793b
to
f023399
Compare
f023399
to
862d081
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. If you can move the test to the correct place, it is good to go for me.
test/schemaValidation.test.ts
Outdated
@@ -1966,5 +1966,17 @@ obj: | |||
expect(result[0].message).to.eq('Matches multiple schemas when only one must validate.'); | |||
expect(telemetry.messages).to.be.empty; | |||
}); | |||
|
|||
it('Unused anchors in an array', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should be in
describe('Unused anchors diagnostics', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've updated an existing test case to have multiple [un]used anchors handling in an array.
862d081
to
1538011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@msivasubramaniaan Can you review and merge this one if it is all right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fixes broken warnings on unused anchors inside an array:
What issues does this PR fix or reference?
Is it tested? How?
Test case included in PR.