fix: nested anyof const #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
suggested changes
Jul 2, 2023
test/schemaValidation.test.ts
Outdated
| }, | ||
| }, | ||
| }; | ||
| languageService.addSchema(SCHEMA_ID, schema); |
There was a problem hiding this comment.
Can you rebase this commit to head and use schemaProvider.addSchema it is the new mechanism for feeding schemas for tests and since we have removed the earlier hack in the parser this will probably fail.
There was a problem hiding this comment.
thanks, @gorkem done,
I also pushed a small change for const matching.
there was a small inconsistency between enum and const match.
Enum allows having a partial match, but const had to be exactly the same.
It's a little bit related to this PR, so sorry for putting it together...
p-spacek
force-pushed
the
fix/nested-anyof-const
branch
from
85360c8
to
17b06d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix validation of nested
anyOfconstsschema:
{ "type": "object", "properties": { "options": { "anyOf": [ { "type": "object", "properties": { "form": { "type": "string" }, "provider": { "type": "string", "const": "test1" } }, "required": [ "form", "provider" ] }, { "type": "object", "properties": { "form": { "type": "string" }, "provider": { "anyOf": [ { "type": "string", "const": "testX" } ] } }, "required": [ "form", "provider" ] } ] } } }will produce this error:
Screen.Recording.2023-06-02.at.12.59.40.mov
note that 'missing form property' is necessary to trigger the bug (there has to be some problem in both subSchemas)
order of the object in
anyOfis also importantWhat issues does this PR fix or reference?
no existing issue
Is it tested? How?
unit test