fix: undefined error in mergingResult.problemArgs #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased and merged manually. If you can "Allow maintainers to make changes to your Pull Request branch" when creating the PR in the future, we can automate the rebase |
oh sure, I didn't know this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix previous issue when
mergingResult.problemArgscould be undefined. Then, the schema parser could end with an error.What issues does this PR fix or reference?
no ref
Is it tested? How?
just manually, not sure when exactly the error occurred, didn't spend much time to find the exact schema definition that caused this issue. But it's obvious that there should be a check, because
problemArgscould be undefined (based on the definition)