feat: unify string insert text for array and property #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
force-pushed
the
feat/unify-string-insert-text-for-array-and-property
branch
from
5a61da9
to
8d26886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
unify string text inserting for array and property
when you choose string property from completion you get
na->name:but for array, it generated extra quotes:
arr->These extra quotes caused, that it wasn't possible to invoke completion just after the code insert, but you had to delete
""continue...the behavior is just a little bit different than for property text inserting.
Screen.Recording.2023-11-08.at.15.14.12.mov
Note that I didn't change it for
numbernor forboolbecause it seems to me a little bit different scenarioWhat issues does this PR fix or reference?
Is it tested? How?
update current tests