Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added severity and labels #153

Merged
merged 6 commits into from
Feb 22, 2022
Merged

added severity and labels #153

merged 6 commits into from
Feb 22, 2022

Conversation

cr-alan
Copy link
Contributor

@cr-alan cr-alan commented Jan 24, 2022

What does this PR do?

This adds severity to the Title of the jira
Also adds the capability to configure labels for jiras created with this tool.

Where should the reviewer start?

Lines were added/changed in SecurityAlertIssue.php
Readme was updated.

How can the reviewer see this in action?

Any background context you want to provide?

Severity is a critical component for prioritization. This deserves a place in the title.
Labels would be a great add-on.

Is this related to processing of personal data?

No

What are the relevant tickets?

Screenshots (if appropriate)

Questions for the reviewer:

@cr-alan cr-alan changed the title added severity added severity and labels Jan 24, 2022
@carlossless
Copy link

Would love to see this introduced! :)

README.md Outdated Show resolved Hide resolved
Co-authored-by: Achton Smidt Winther <[email protected]>
@cr-alan
Copy link
Contributor Author

cr-alan commented Feb 10, 2022

Curious to see if this will get merged in?

@kasperg kasperg requested a review from a team February 11, 2022 12:24
Copy link
Member

@xendk xendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good. I've let phpcs and phpstan run, and there's a few style issues to fix. I've summarized them in comments.

src/SecurityAlertIssue.php Outdated Show resolved Hide resolved
src/SecurityAlertIssue.php Outdated Show resolved Hide resolved
src/SecurityAlertIssue.php Show resolved Hide resolved
fixed style

Co-authored-by: Thomas Fini Hansen <[email protected]>
@drchiodo
Copy link

up

@xendk
Copy link
Member

xendk commented Feb 22, 2022

OK, one PHPCS notice left. I'll merge and fix it afterwards.

@xendk xendk merged commit 0eb736f into reload:v1.x Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants