-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added severity and labels #153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would love to see this introduced! :) |
achton
reviewed
Jan 26, 2022
Co-authored-by: Achton Smidt Winther <[email protected]>
Curious to see if this will get merged in? |
xendk
requested changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically looks good. I've let phpcs and phpstan run, and there's a few style issues to fix. I've summarized them in comments.
fixed style Co-authored-by: Thomas Fini Hansen <[email protected]>
up |
OK, one PHPCS notice left. I'll merge and fix it afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds severity to the Title of the jira
Also adds the capability to configure labels for jiras created with this tool.
Where should the reviewer start?
Lines were added/changed in SecurityAlertIssue.php
Readme was updated.
How can the reviewer see this in action?
Any background context you want to provide?
Severity is a critical component for prioritization. This deserves a place in the title.
Labels would be a great add-on.
Is this related to processing of personal data?
No
What are the relevant tickets?
Screenshots (if appropriate)
Questions for the reviewer: