Add support for vulnerabilities with no fix #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnested
force-pushed
the
no-fix
branch
4 times, most recently
from
242ab6d
to
1f2f529
Compare
rasben
previously approved these changes
Oct 2, 2020
arnested
requested review from
rasben and
a team
and removed request for
rasben
Sometimes there is no (known) fix for a vulnerability. Before this fix the code would fail in those situations: ``` Fatal error: Uncaught TypeError: Typed property GitHubSecurityJira\SecurityAlertIssue::$safeVersion must be string, null used in /opt/ghsec-jira/src/SecurityAlertIssue.php:41 ```
rasben
approved these changes
Oct 3, 2020
xendk
reviewed
Oct 5, 2020
| @@ -91,10 +98,13 @@ public function __construct(array $data) | |||
| */ | |||
| public function uniqueId(): string | |||
| { | |||
| // If there is no safe version we use the GHSA ID as identifier. | |||
| $identifier = $this->safeVersion ?? $this->id; | |||
There was a problem hiding this comment.
This means that if a fix becomes available, it'll create a new ticket. Which is good, but shouldn't this side effect be mentioned in a comment?
arnested
added a commit
that referenced
this pull request
Oct 5, 2020
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is no (known) fix for a vulnerability.
Before this fix the code would fail in those situations: