Fix coverage for matches containing a single case. #626
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C backend tries not to emit branch coverage points for matches containing a single case but was still emitting a line in all_branches. This confused sailcov and resulting in warnings and weird output. Hopefully fixes #502. Also adds a test case containing a tuple deconstruction (which apparently gets compiled to a single case match).
|
Ah, I think we simultaneously fixed the issue. |
|
Already fixed by 09ac4b2. |
|
Thanks both for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C backend tries not to emit branch coverage points for matches
containing a single case but was still emitting a line in
all_branches. This confused sailcov and resulting in warnings and
weird output. Hopefully fixes #502. Also adds a test case containing
a tuple deconstruction (which apparently gets compiled to a single
case match).