Skip to content

Commit

Permalink
Avoid setup-java step on GH Actions if possible (#39)
Browse files Browse the repository at this point in the history
All GH Action runner images have Java pre-installed. Both
ubuntu-latest and macos-latest have Java 11+ as default. Only
windows-latest has Java 8 as default. So avoid a superfluous
setup-java step in all jobs except the tests on windows-latest.
  • Loading branch information
akosthekiss committed Nov 4, 2023
1 parent 2adac94 commit a1003d4
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
with:
java-version: 17
distribution: temurin
if: matrix.os == 'windows-latest'
- run: pip install --upgrade tox
- run: tox -v -e py

Expand All @@ -43,10 +44,6 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: '3.x'
- uses: actions/setup-java@v3
with:
java-version: 17
distribution: temurin
- run: pip install --upgrade tox coveralls
- run: tox -v -e cov
- run: coveralls --service=github
Expand Down

0 comments on commit a1003d4

Please sign in to comment.