fix(manager/circleci): optional jobs parameter (#30251)

renovatebot · Jul 19, 2024 · 7272dd2 · 7272dd2
1 parent 8a5e291
commit 7272dd2
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 2 deletions.
diff --git a/lib/modules/manager/circleci/__fixtures__/config4.yml b/lib/modules/manager/circleci/__fixtures__/config4.yml
@@ -0,0 +1,9 @@
+version: 2.1
+
+orbs:
+  nodejs: circleci/[email protected]
+
+workflows:
+  Test:
+    jobs:
+      - nodejs/test
diff --git a/lib/modules/manager/circleci/extract.spec.ts b/lib/modules/manager/circleci/extract.spec.ts
@@ -4,6 +4,7 @@ import { extractPackageFile } from '.';
 const file1 = Fixtures.get('config.yml');
 const file2 = Fixtures.get('config2.yml');
 const file3 = Fixtures.get('config3.yml');
+const file4 = Fixtures.get('config4.yml');
 
 describe('modules/manager/circleci/extract', () => {
   describe('extractPackageFile()', () => {
@@ -65,5 +66,17 @@ describe('modules/manager/circleci/extract', () => {
         ),
       ).toBeNull();
     });
+
+    it('extracts orbs without jobs', () => {
+      const res = extractPackageFile(file4);
+      expect(res?.deps).toMatchObject([
+        {
+          depName: 'nodejs',
+          currentValue: '5.2.0',
+          datasource: 'orb',
+          depType: 'orb',
+        },
+      ]);
+    });
   });
 });
diff --git a/lib/modules/manager/circleci/extract.ts b/lib/modules/manager/circleci/extract.ts
@@ -30,7 +30,7 @@ export function extractPackageFile(
       });
     }
 
-    for (const job of Object.values(parsed.jobs)) {
+    for (const job of Object.values(parsed.jobs ?? {})) {
       for (const dockerElement of coerceArray(job.docker)) {
         deps.push({
           ...getDep(dockerElement.image),

diff --git a/lib/modules/manager/circleci/schema.ts b/lib/modules/manager/circleci/schema.ts
@@ -10,6 +10,6 @@ export const CircleCiJob = z.object({
 
 export const CircleCiFile = z.object({
   aliases: z.array(CircleCiDocker).optional(),
-  jobs: z.record(z.string(), CircleCiJob),
+  jobs: z.record(z.string(), CircleCiJob).optional(),
   orbs: z.record(z.string()).optional(),
 });