Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): add mise package manager #29950

Merged
merged 44 commits into from
Jul 8, 2024

Conversation

james0209
Copy link
Contributor

@james0209 james0209 commented Jun 30, 2024

Changes

Add support for the mise package manager: https://mise.jdx.dev/getting-started.html

mise has it's own TOML file - .mise.toml - which is an extension of asdf's .tool-versions

Context

Closes #28918

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@james0209 james0209 requested a review from rarkins July 1, 2024 13:00
lib/modules/manager/mise/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mise/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mise/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mise/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/mise/extract.ts Outdated Show resolved Hide resolved
@james0209 james0209 requested a review from secustor July 1, 2024 19:11
lib/modules/manager/mise/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/mise/utils.ts Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
secustor
secustor previously approved these changes Jul 4, 2024
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for a review @HonkingGoose before merging.

Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are nearly good to go, some small style fixes.

Changes:

  • Swap some difficult words for simple words
  • Drop . at the end of list items
  • Rewrite some sentences
  • Use monospace styling for some things

By the way, we have a Style Guide for user-facing text. That explains why I'm making some changes, that may look weird at first, like the . at the end of lists. 😉

lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review, I promise! 😉

lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/mise/readme.md Outdated Show resolved Hide resolved
@secustor secustor enabled auto-merge July 5, 2024 15:02
@james0209
Copy link
Contributor Author

@rarkins can you give this PR some 👀 please? It can't be merged until you re-review it - thanks

@secustor secustor added this pull request to the merge queue Jul 8, 2024
Merged via the queue into renovatebot:main with commit 4a304b8 Jul 8, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.426.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New package manager: "mise-en-place"
6 participants