Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to provide instructions for base64-encoding image inputs #244

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

GothReigen
Copy link
Contributor

@GothReigen GothReigen commented Feb 9, 2024

Context

Update sign-off prior commit in git history (cd09db0) + Add basic base64 example

@GothReigen GothReigen requested a review from mattt February 9, 2024 07:18
@GothReigen GothReigen marked this pull request as ready for review February 16, 2024 10:56
Co-authored-by: GothReigen <[email protected]>

Signed-off-by: Mattt Zmuda <[email protected]>
README.md Outdated Show resolved Hide resolved
@mattt mattt changed the title Update commit sign-off Update REAME to provide instructions for base64-encoding image inputs Feb 17, 2024
@mattt mattt changed the title Update REAME to provide instructions for base64-encoding image inputs Update README to provide instructions for base64-encoding image inputs Feb 19, 2024
@mattt
Copy link
Member

mattt commented Feb 19, 2024

@GothReigen Thanks for opening this PR. As I mentioned in https://github.com/replicate/replicate-python/pull/244/files#r1493371435, I believe this base64-encoding behavior is automatically provided for file handles. Can you think of any reason not to use that?

@GothReigen
Copy link
Contributor Author

I believe this base64-encoding behavior is automatically provided for file handles. Can you think of any reason not to use that?

I missed that, thank you for pointing it out! Updated the example for making a prediction request using a local file (and calling out that files.py handles the base64 encoding).

Signed-off-by: Mattt Zmuda <[email protected]>
@mattt
Copy link
Member

mattt commented Feb 19, 2024

@GothReigen I think the discussion a few lines up in the README does a sufficient job of conveying this information. I just pushed 6725e82, which updates the existing example with your changes.

Thanks again for your contribution. Merging now.

@mattt mattt merged commit 63764dc into main Feb 19, 2024
8 checks passed
@mattt mattt deleted the update-commit branch February 19, 2024 13:20
GothReigen added a commit that referenced this pull request Mar 11, 2024
#244)

### Context

Update sign-off prior commit in git history
(cd09db0)
+ Add basic base64 example

---------

Signed-off-by: Mattt Zmuda <[email protected]>
Co-authored-by: GothReigen <[email protected]>
Co-authored-by: Mattt Zmuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants