🐛 Remove call to removeprefix to fix python 3.8 #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
stream.py
we were usingremoveprefix
, which was introduced in Python 3.9. This breaks compatibility with Python 3.8, which I believe we still want to support. This PR provides exact same functionality but without the call to that function.Previously, we were
.lstrip()
-ing here, but I assume @mattt switched toremoveprefix
for a reason, so I didn't use that (as it would get rid of any and all whitespace, as opposed to a single space as we do here).