Instance per workspace #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, once a second dropdown on a second workspace is initiated, the _map_ signal does not fire anymore und thus leaves the dropdown in a incomplete state. Removing the _map_ signal completely does work. However, now the first dropdown is fired up in maximized mode.
The first dropdown gets maximized during Main.activateWindow. Hence, immediately unmaximize it. Causes a nasty glitch though.
freimair
force-pushed
the
feature/per_workspace
branch
from
5c81060
to
714bdb6
Compare
|
rebased the changes to v8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
Finally I found some time to create the instance per workspace feature. (Did that for guake a while ago but then wayland and API changes came along and I ended up with this great extension).
Tested on X11 and Wayland, Gnome Shell 41.3
Now, a word of caution. I had to remove some code to get it working, waiting for a signal to be exact. I haven't had the time to figure out why this piece of code has been there in the first place. However, by removing the wait, I managed to achieve what I was looking for. Only thing remaining is that since now the very first drop-down after extension load starts in maximized window mode and the code immediately reverts the maximization, there are some fast resizings going on when you first press the hotkey. All subsequent uses of the hotkey do not have those glitches.
Maybe you guys can share some insight?