Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA and IN lower gov #243

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

PA and IN lower gov #243

wants to merge 2 commits into from

Conversation

KhanhNham
Copy link

Replace PR for PA and IN reps forms


- visit: "https://indianahousedemocrats.org/members/vernon-smith/full#form_individual-member-contact"
- fill_in:
- name: full_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tabbing.

Comment on lines 38 to 40

#Skipped the file upload section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove. (We know we're not uploading any files.)

value: $SUBJECT
required: true
- name: message
selector: "input[name=message]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selector is textarea

Comment on lines 41 to 48
- name: subject_line
selector: "input[name=subject_line]"
value: $SUBJECT
required: true
- name: message
selector: "input[name=message]"
value: $MESSAGE
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tabbing

Comment on lines 49 to 51
- name: g-recaptcha-response
selector: '#g-recaptcha-response'
value: $CAPTCHA_SOLUTION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary. Generally, only the 'recaptcha' directive is required. There are some rare circumstances when we have to issue instructions on the recaptchas.

- recaptcha:
- value: true

success:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tabbing. (Should be in line with "steps:")

Comment on lines 52 to 55
- click_on:
- value: "button[class='button']"
- recaptcha:
- value: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move captcha above the final button click. (We need to solve the captcha before we click the button to submit the form.)

Comment on lines 52 to 53
- click_on:
- value: "button[class='button']"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things here - First, you want a 'selector' directive to target the element. Second, there are three buttons on the page defined like this. if you use "button[class='button']" it will click the first button that matches that selector, which is higher on the page and not the one you are looking for. You'll have to include additional attributes as part of the selector to hit the right button. Give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants