Add new GH shellcheck action #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @alknopfler |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Triggering the test-ci manually, we'll merge the PR once the test has passed. |
|
I have updated the branch just to make sure that all the latest changes pass the checks too. /lgtm |
iranzo
suggested changes
Jun 13, 2022
There was a problem hiding this comment.
@leo8a sorry for the delay, but the pipe was not in shape for doing the testing.
We realized that with this PR in place, it breaks apparently the copy of some files and hence, the installation fails:
This works fine on main branch.
I would suggest to split this into different PR's:
- One for the GHA for the checks
- One PR for each of the file changes, in that way, we run the pipe to see if it gets affected on that specific file and change without having to debug or rework on it as a whole
What do you think?
leo8a
changed the title
|
Thanks @leo8a! Rebasing the PR branch and testing again. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This GH action checks (in every commit to main) the shell scripts. Will only flag `severity: error` level problems as failures. Feel free to add `warnings` as error too if you need so.
iranzo
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GH action that checks errors in shell scripts for every commit to main. As a complement, fixes to pass the shellcheck linter can be found in #397, #398, #399, #400, and #401.
Signed-off-by: Leo Ochoa [email protected]