Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Use factory.local for the hosts #358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iranzo
Copy link
Contributor

@iranzo iranzo commented Jun 2, 2022

Description

Standardize on the branding of the solution

Closes #356

@alknopfler
Copy link
Contributor

Please, remember hosts must be updated with DNS and the rest of the team QE, UI, (maybe partners) should be noticed just to ensure everybody uses new domain in their environments

@alknopfler
Copy link
Contributor

An idea to test it, could be use a host, remove it from ci-pool, remove the dnsmasq configurations manually, clone repo, run manually the lab-dns script to test it as a hostand then pass the CI (adding it again to the ci pool)...

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@flaper87
Copy link
Contributor

An idea to test it, could be use a host, remove it from ci-pool, remove the dnsmasq configurations manually, clone repo, run manually the lab-dns script to test it as a hostand then pass the CI (adding it again to the ci pool)...

👍 let's please run a full e2e tests for this PR:

  • Clean host, no hub
  • deploy everything.
  • screenshots
  • profit

@flaper87
Copy link
Contributor

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use factory.local as domain in the environment
3 participants