Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy-metallb to pass shellcheck linter #400

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

Fix deploy-metallb to pass shellcheck linter #400

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e78b5c0
Fix deploy-metallb to pass shellcheck linter
leo8a Jun 14, 2022
cb8ff8d
Merge branch 'main' into fix-deploy-metallb
iranzo Jun 28, 2022
acaf798
Merge branch 'main' into fix-deploy-metallb
flaper87 Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions deploy-metallb/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ function copy_files() {
dst_folder=${3}

if [[ -z ${src_files} ]]; then
echo "Source files variable empty: ${src_files[@]}"
echo "Source files variable empty:" "${src_files[@]}"
exit 1
fi

Expand All @@ -206,8 +206,8 @@ function copy_files() {
exit 1
fi

echo "Copying source files: ${src_files[@]} to Node ${dst_node}"
${SCP_COMMAND} -i ${RSA_KEY_FILE} ${src_files[@]} core@${dst_node}:${dst_folder}
echo "Copying source files:" "${src_files[@]}" "to Node ${dst_node}"
${SCP_COMMAND} -i ${RSA_KEY_FILE} "${src_files[@]}" core@${dst_node}:${dst_folder}
}

function check_external_access() {
Expand Down Expand Up @@ -272,7 +272,7 @@ if ! ./verify.sh; then
# Remote working
echo ">> Copying files to the Edge-cluster ${edgecluster}"
${SSH_COMMAND} -i ${RSA_KEY_FILE} core@${EDGE_NODE_IP} "mkdir -p ~/manifests ~/.kube"
for _file in ${files[@]}; do
for _file in "${files[@]}"; do
copy_files "${_file}" "${EDGE_NODE_IP}" "./manifests/"
done
copy_files "./manifests/*.yaml" "${EDGE_NODE_IP}" "./manifests/"
Expand Down