Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Fix use of deprecated MetalLB CRDs in UI #827

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-ISSUE: Fix use of deprecated MetalLB CRDs in UI #827

wants to merge 1 commit into from
+8 −8

Conversation

jhernand
Copy link
Collaborator

Description

Currently the UI tries to create/modify the deprecated AdressPool object, but that object is no longer used in the current MetalLB configuration because it has been replaced by IPAddressPool. This patch adjusts the UI accordingly.

Type of change

Please select the appropriate options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Testing

Tested manually.

Checklist

  • I have performed a self-review of my own code
  • If a change is adding a feature, it should require a change to the README.md and the review should catch this.
  • If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
  • A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
  • PRs should not be merged unless positively reviewed.

@jhernand
NO-ISSUE: Fix use of deprecated MetalLB CRDs in UI
42692cc 
Currently the UI tries to create/modify the deprecated `AdressPool`
object, but that object is no longer used in the current MetalLB
configuration because it has been replaced by `IPAddressPool`. This
patch adjusts the UI accordingly.

Signed-off-by: Juan Hernandez <[email protected]>
@jhernand
Copy link
Collaborator Author

@mareklibra please take a look.

@github-actions github-actions bot added test-ci-ui Force run UI test ui labels Mar 16, 2023
eranco74
eranco74 reviewed May 3, 2023
View reviewed changes
ui/frontend/src/components/PersistPage/resourceTemplates.ts
apiVersion: 'metallb.io/v1alpha1',
kind: 'AddressPool',
apiVersion: 'metallb.io/v1beta1',
kind: 'IPAddressPool',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike AddressPool IPAddressPool is used only for the ip assignment part. In order to advertise the IP you should create L2Advertisement.

https://github.com/metallb/metallb/blob/main/configsamples/simple_pool_adv_l2.yaml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the advertisements for the ingress and API are created here and here. That was updated when we switched to the new version of MetalLB. The problem is the UI wasn't updated accordingly.

@jhernand jhernand mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranco74 eranco74 eranco74 left review comments

Assignees
No one assigned
Labels
size/S test-ci-ui Force run UI test ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhernand @eranco74