-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to rescript #75
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I was just starting to look into using Reductive with ReScript.
I noticed some converted code that might not be idiomatic / officially supported in ReScript. Also, the README still contains references to Reason.
| B => state ++ "b" | ||
} | ||
|
||
type ReduxThunk.thunk<_> += |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is idiomatic / officially supported in ReScript: rescript-association/rescript-lang.org#135
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supported (talking about current state) but not documented just like row polymorphism and other advanced stuff.
but definitely examples need some improvement.
} | ||
|
||
let thunkedLoggedTimeTravelLogger = (store, next) => | ||
\"@@"(Middleware.thunk(store), \"@@"(Middleware.logger(store), \"@@"(timeTravel(store), next))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the @@
operator officially exists in ReScript. It is not listed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the application operator is not supported.
@amiralies Do you intend to continue working on this PR? Can you use help? |
@Minnozz I can address the issues but I'm curious if ricky @rickyvetter willing to continue maintaining this since I didn't get response from him |
@amiralies, I like your pr, today I build you branch on my machine and found it build successfully! but I can't build successfully in the master branch. But when I run the example of todomvcEntry.res, it doesn't work, the I just got blank browser page. |
closes #74
What does this PR do: