started work on abstraction layer, wrapped original implementaton #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihp
requested changes
May 14, 2023
| str: the task id""" | ||
| pass | ||
|
|
||
| def complete_task(self, task: PlannerTask, name: str = "PlannerGPT"): |
There was a problem hiding this comment.
essentally this allows a storage implementation to keep multiple instances apart (thats once the name is actually injected, which it isn't yet)
| "get_next_task", | ||
| "Returns the task you are supposed to work on", | ||
| {}, | ||
| get_current_task |
There was a problem hiding this comment.
is this the right function to call ?
There was a problem hiding this comment.
yes, get next task is aliasing get_current_task, just so it is less likely to stumble over making the distinction
ppetermann
commented
May 24, 2023
|
|
||
| self.planner = Planner(get_planner( | ||
| agent_id=settings.ai_name, | ||
| implementation_name="SqlitePlanner" # TODO: make this configurable |
There was a problem hiding this comment.
should make this configureable before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT
Description
This PR bundles the work to abstract the implementations in the planner, which is supposed to allow other/more complex
storage implementations (for example sqliite)