Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bytestring): support ::string type in construction patterns #60

Merged
merged 6 commits into from
Feb 26, 2024
Merged

feat(bytestring): support ::string type in construction patterns #60

merged 6 commits into from
Feb 26, 2024

Conversation

wesleimp
Copy link
Contributor

Closes #47

leostera
leostera reviewed Feb 26, 2024
View reviewed changes
bytestring/ppx.t/run.t Outdated Show resolved Hide resolved
leostera
leostera reviewed Feb 26, 2024
View reviewed changes
bytestring/bytestring.mli Outdated Show resolved Hide resolved
leostera
leostera approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@leostera leostera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@leostera leostera merged commit 9d84608 into riot-ml:main Feb 26, 2024
2 checks passed
@leostera
Copy link
Collaborator

Thanks @wesleimp for this PR! ✨

@leostera leostera mentioned this pull request Feb 26, 2024
Closed
@wesleimp wesleimp deleted the feat/string-type-construction-patterns branch February 26, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leostera leostera leostera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ::string type in bytestring construction patterns
2 participants
@wesleimp @leostera