Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning 53 (unboxed attribute used in the wrong location) #83

Merged
merged 1 commit into from
May 31, 2024

Conversation

lthms
Copy link
Contributor

@lthms lthms commented May 26, 2024

When running dune build @check from the root of the repository, here is one instance of the warning 53 I get.

File "riot/runtime/core/proc_effect.ml", line 23, characters 5-12:
23 |   [@@unboxed]
          ^^^^^^^
Error (warning 53 [misplaced-attribute]): the "unboxed" attribute
cannot appear in this context

This patch removes the incorrect unboxed attribute where needed, to make the codebase warning free.

When running `dune build @check` from the root of the repository, here is one
instance of the warning 53 I get.

    File "riot/runtime/core/proc_effect.ml", line 23, characters 5-12:
    23 |   [@@unboxed]
              ^^^^^^^
    Error (warning 53 [misplaced-attribute]): the "unboxed" attribute
    cannot appear in this context

This patch removes the incorrect `unboxed` attribute where needed, to make the
codebase warning free.
@leostera leostera merged commit 8b70e2a into riot-ml:main May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants