Fix compilation unit name conflicts with runtime sub-libraries (e.g. core) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @leviroth! Thanks for the PR ✨ – this looks good to me, just need some rebasing and we should be good to merge :) |
The libraries in subdirectories under `riot/runtime` have been merged into `runtime` itself. In various places we now need to refer to (e.g.) `Runtime.Core` instead of `Core` directly. To avoid name conflicts with the `Runtime` module itself (including via `Lib.Runtime`), I renamed `runtime` to `riot_runtime`. In all, the following compilation unit names have been purged from the global namespace: - Core - Log - Runtime - Scheduler - Time - Util
leviroth
force-pushed
the
fix-core-name-conflict
branch
from
7af319d
to
dacb66d
Compare
|
Thanks for the contrib @leviroth! 🙏🏼 This should make it easier to try Riot with busy opam switches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19.
N.b. There are still libraries named
lib,global, andloggerin this package. Since those names are pretty generic, it might be a good idea to do similar work to eliminate them.