Skip to content

Commit

Permalink
Remove _DEP requirement (#167)
Browse files Browse the repository at this point in the history
The OSPM can add IRQ dependencies by looking at GSI map. So, the
requirement of adding _DEP under each device which needs GSIs (wired
interrupts) is no longer required. Remove the requirement.

Signed-off-by: Sunil V L <[email protected]>
  • Loading branch information
vlsunil committed May 29, 2024
1 parent 74d733c commit 4e7fb00
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
9 changes: 2 additions & 7 deletions acpi.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ available to an OS loader via the standard `UEFI EFI_GRAPHICS_OUTPUT_PROTOCOL` i
| [[acpi-namespace-dev]]`ACPI_080` | PLIC/APLIC namespace devices MUST
be present in the ACPI namespace whenever corresponding MADT entries are
present. <<acpi-ids, See RVI ACPI IDs>>.
2+| _Also see <<acpi-irq-gsb, AML_090>>, <<acpi-irq-dep, AML_100>> and <<acpi-guidance-gsi-namespace, additional guidance>>_.
2+| _Also see <<acpi-irq-gsb, AML_090>> and <<acpi-guidance-gsi-namespace, additional guidance>>_.
|===

[[acpi-aml]]
Expand Down Expand Up @@ -76,12 +76,7 @@ through the driver-backed `OperationRegion`._
| [[acpi-irq-gsb]] `AML_090` | PLIC and APLIC device objects MUST support
the Global System Interrupt Base (`_GSB`, cite:[ACPI] Section 6.2.7) object.
<<acpi-guidance-gsi-namespace, See additional guidance>>.
| [[acpi-irq-dep]] `AML_100` | Devices with Global System
Interrupt (GSI, aka wired interrupt) resources MUST indicate the dependency on the corresponding
interrupt controller using Operation Region Dependencies (`_DEP`,
cite:[ACPI] Section 6.5.8).
<<acpi-guidance-gsi-namespace, See additional guidance>>.
| `AML_110` | UART device objects with ID `RSCV0003` MUST implement <<acpi-props-uart, Properties for UART Devices>>.
| `AML_100` | UART device objects with ID `RSCV0003` MUST implement <<acpi-props-uart, Properties for UART Devices>>.
|===

include::acpi-id.adoc[]
Expand Down
14 changes: 10 additions & 4 deletions non-normative/acpi.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ describe affinities.
[[acpi-guidance-gsi-namespace]]
==== PLIC/APLIC Namespace Devices

Here's an example of an ASL excerpt satisfying <<acpi-namespace-dev, `ACPI_080`>>,
<<acpi-irq-dep, `AML_090`>> and <<acpi-irq-gsb, `AML_100`>> requirements.
Here's an example of an ASL excerpt satisfying <<acpi-namespace-dev, `ACPI_080`>>
and <<acpi-irq-gsb, `AML_090`>> requirements.

Scope (\_SB)
{
Expand All @@ -118,12 +118,18 @@ Here's an example of an ASL excerpt satisfying <<acpi-namespace-dev, `ACPI_080`>
Name (_UID, Zero) // _UID: Unique ID
Method(_GSB) {
Return (0x10) // Global System Interrupt Base for this PLIC starts at 16
}
}
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0x0C000000, // Address Base.
0x00220000, // Address Length
)
})
}
Device (DEV1)
{
...
Name (_DEP, Package() {\_SB.IC00})
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
Expand Down

0 comments on commit 4e7fb00

Please sign in to comment.