Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: ACPI - Define AML device for SPCR type 0x12 devices #24

Closed
andreiw opened this issue Mar 30, 2023 · 7 comments
Closed

Dependency: ACPI - Define AML device for SPCR type 0x12 devices #24

andreiw opened this issue Mar 30, 2023 · 7 comments

Comments

@andreiw
Copy link
Collaborator

andreiw commented Mar 30, 2023

Type 0x12 can describe NS16550-like UARTs that cannot be described by PNP0501 - the e.g. register stride, clock frequency. And there are other "tunables" which may be interesting to the OS driver. This should have it's own ACPIxxxx _CID.

Can model this on https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/serial/8250.yaml.

These seem like a good set. Should these use DSD DT?

  • clock-frequency
  • reg-offset
  • reg-shift
  • reg-io-width
  • fifo-size
@andreiw andreiw changed the title Define AML device for SPCR type 0x12 devices Dependency: ACPI - Define AML device for SPCR type 0x12 devices Mar 30, 2023
@adurbin-rivos
Copy link
Collaborator

'DSD DT' - what do you mean by this? device specific data and have that under a specific ACPIxxxx device name?

@paul-walmsley-sifive
Copy link
Contributor

'DSD DT' - what do you mean by this? device specific data and have that under a specific ACPIxxxx device name?

He's probably referring to the practice of embedding DT properties into the _DSD entries, i.e., https://docs.kernel.org/6.2/firmware-guide/acpi/dsd/graph.html

@adurbin-rivos
Copy link
Collaborator

Yes, that was my question confirming if DSD DT meant that. I assumed so, but I wanted to be sure.

@andreiw
Copy link
Collaborator Author

andreiw commented Apr 12, 2023

Yes, Paul is correct.

@andreiw
Copy link
Collaborator Author

andreiw commented Apr 11, 2024

This would be nice to have but ideally is code-first and fueled by someone who needs it

@andreiw
Copy link
Collaborator Author

andreiw commented Apr 15, 2024

reg-offset is not necessary (there's nothing matching that in SPCR)

andreiw added a commit to andreiw/riscv-os-a-see-wip that referenced this issue Apr 15, 2024
andreiw added a commit to andreiw/riscv-os-a-see-wip that referenced this issue Apr 15, 2024
andreiw added a commit to andreiw/riscv-os-a-see-wip that referenced this issue Apr 15, 2024
@andreiw
Copy link
Collaborator Author

andreiw commented Apr 15, 2024

Also need to add the rscv- Known Device Property Prefixex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants