-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunil's feedback on allowing RSCV IDs to be used as either HID or CID. #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. Otherwise LGTM.
acpi.adoc
Outdated
@@ -33,7 +33,7 @@ available to an OS loader via the standard `UEFI EFI_GRAPHICS_OUTPUT_PROTOCOL` i | |||
* Revision 4 or later of SPCR. | |||
* For NS16550-compatible UARTs: | |||
** Use `Interface Type` 0x12 (16550-compatible with parameters defined in Generic Address Structure). | |||
** There MUST be a matching AML device object with compatible ID `RSCV0003`. | |||
** There MUST be a matching AML device object with `_HID` (Hardware ID) or `_CID` (Compatibility ID) `RSCV0003`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding HID as well. ACPI spec (6.1.2) refers as Compatible ID itself. So, better to have "Compatible ID" instead of "Compatibility ID" ?
non-normative/acpi.adoc
Outdated
@@ -150,7 +150,7 @@ and <<acpi-irq-gsb, `AML_090`>> requirements. | |||
|
|||
On some architectures, it became an industry accepted norm to describe PCIe implementations not compliant to the _PCI Firmware Specification_ cite:[PCIFW] | |||
using specification-defined ACPI tables and objects. RISC-V systems compliant to the BRS must only expose ECAM-compatible implementations using the | |||
MCFG and the standard AML Hardware ID (`_HID`) `PNP0A08` and Compatible ID (`_CID`) `PNP0A03`, and must not rely on ACPI table header information or other out-of-band means of detecting quirked behavior. | |||
MCFG and the standard AML Hardware ID (`_HID`) `PNP0A08` and Compatibility ID (`_CID`) `PNP0A03`, and must not rely on ACPI table header information or other out-of-band means of detecting quirked behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this change is not required.
Signed-off-by: Andrei Warkentin <[email protected]>
No description provided.