Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support #4

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Add Windows support #4

merged 1 commit into from
Oct 17, 2019

Conversation

kenkangxgwe
Copy link
Contributor

@kenkangxgwe kenkangxgwe commented Oct 16, 2019

  • Upgrade FindMathematica to version 3.2.5.
  • Upgrade linenoise to linenoise-ng as submodule.
  • Update the documentation to mention using git submodule update --init.
  • The linenoise-ng contains multiple licenses and I added it as a submodule, maybe the LICENSE file need not be copied to the root directory.
  • Also could you test it under macOS or Linux to make sure it doesn't break?

Hi @rljacobson , I wonder if you can help me with the last two items?

* Upgrade FindMathematica to version 3.2.5.
* Upgrade linenoise to linenoise-ng as submodule.
@rljacobson
Copy link
Owner

Awesome! It seems to work on my Macs.

I think we should add popl and FindMathematica as a submodules, too, while we're at it. I'll do that as a separate commit along with the license and README changes you suggested. Good ideas.

@rljacobson rljacobson marked this pull request as ready for review October 17, 2019 00:23
@rljacobson rljacobson merged commit 9a4ceff into rljacobson:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants