Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflicts between mujoco-py and gym temporarily #2188

Merged
merged 5 commits into from
Dec 1, 2020

Conversation

yeukfu
Copy link
Contributor

@yeukfu yeukfu commented Dec 1, 2020

Pip release 20.3 today, which makes the CI build failed. Here is the log, and the related issue.

@yeukfu yeukfu requested a review from a team as a code owner December 1, 2020 02:00
@mergify mergify bot requested review from a team and maliesa96 and removed request for a team December 1, 2020 02:01
@mergify mergify bot requested a review from a team December 1, 2020 02:02
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #2188 (9ca6a91) into master (f856f74) will decrease coverage by 0.19%.
The diff coverage is 94.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   91.36%   91.17%   -0.20%     
==========================================
  Files         198      198              
  Lines       10944    10912      -32     
  Branches     1374     1367       -7     
==========================================
- Hits         9999     9949      -50     
- Misses        688      703      +15     
- Partials      257      260       +3     
Impacted Files Coverage Δ
src/garage/tf/algos/_rl2npo.py 100.00% <ø> (ø)
src/garage/tf/algos/erwr.py 44.44% <ø> (ø)
src/garage/tf/algos/ppo.py 66.66% <ø> (ø)
src/garage/tf/algos/rl2ppo.py 100.00% <ø> (ø)
src/garage/tf/algos/rl2trpo.py 100.00% <ø> (ø)
src/garage/tf/algos/te_ppo.py 100.00% <ø> (ø)
src/garage/tf/algos/tnpg.py 72.72% <ø> (ø)
src/garage/tf/algos/trpo.py 100.00% <ø> (ø)
src/garage/tf/algos/vpg.py 72.72% <ø> (ø)
src/garage/torch/algos/maml_ppo.py 100.00% <ø> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8aaef2...9ca6a91. Read the comment docs.

@ryanjulian
Copy link
Member

Unfortunately, the only way to solve this is to fix the build under the new pip -- we have no control over which version of pip people use, and when in doubt we should use the latest.

@yeukfu yeukfu changed the title Pin pip to 20.2.4 Resolve conflicts between mujoco-py and gym temporarily Dec 1, 2020
Copy link
Contributor

@krzentner krzentner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to setup.py explaining what's going on here? As is this change is pretty unclear.

@yeukfu
Copy link
Contributor Author

yeukfu commented Dec 1, 2020

Can you add a comment to setup.py explaining what's going on here? As is this change is pretty unclear.

Sure

@mergify mergify bot merged commit 9a2a0bb into master Dec 1, 2020
@mergify mergify bot deleted the rf-constraint-pip-version branch December 1, 2020 21:19
irisliucy pushed a commit that referenced this pull request Mar 19, 2021
* Pin pip to 20.2

* Pin pip to 20.2.4

* Pin pip to 20.2.4

* Resolve conflict between mujoco-py and gym

* Add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants