-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate typing into source #345
Conversation
b84d0e1
to
6b565aa
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 14 -1
Lines 1957 1927 -30
Branches 577 351 -226
==========================================
- Hits 1957 1927 -30
☔ View full report in Codecov by Sentry. |
0a7c981
to
576dc8b
Compare
src/qbittorrentapi/request.py
Dismissed
resp_logger("Request Headers: %s", response.request.headers) | ||
resp_logger("Request HTTP Data: %s", {"data": data, "params": params}) | ||
if "auth/login" not in url: | ||
resp_logger("Request HTTP Data: %s", {"data": data, "params": params}) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
This expression logs
sensitive data (password)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False positive. Disabled by default and sensitive information from auth/login
won't ever be printed.
75ffd0d
to
a2b15f1
Compare
a2b15f1
to
f655ea7
Compare
Changes
pyi
files in to thepy
source filespyi
is seemingly much less robust asmypy
was much more vigilant about issueshash
andhashes
arguments for API methods is now unsupported and any uses must be updated to usetorrent_hash
andtorrent_hashes
, respectively.TypedDict
....unfortunately, you cannot useTypedDict
withGeneric
until Python 3.11.AttrDict
base will still cause conflicts...and I'm quite hesitant to rip that out...even if I almost certainly wouldn't have included this if I rewrote all this.