Plugin fibre section #295
Merged
Plugin fibre section #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick comment before reviewing in depth - rather than creating a completely new sub-package |
robbievanleeuwen
requested changes
Oct 1, 2023
There was a problem hiding this comment.
LGTM - comments only relating to documentation.
FYI built docs for this PR can be found here.
robbievanleeuwen
approved these changes
Oct 1, 2023
robbievanleeuwen
merged commit 6899912
into
robbievanleeuwen:hypermodern
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to export geometry/section to fibre sections.