-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slab pool boundary guard #585
Slab pool boundary guard #585
Conversation
Thanks for PR, will review in upcoming days! Android timeout is a known issue, I've restarted CI. |
Currently, I put a boundary before and after user the data area. But, it just occurred to me that if the user data area is already padded (max-alignment) - should we also check that for buffer overruns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the patch, looks fine. Here are some comments.
Thanks for update! Here is a small follow-up commit: c25b331 It adds name to other panics, and fixes small bug: if ((flags_ & PoolFlag_PanicOnOverflow) == 1) { will work only if PoolFlag_PanicOnOverflow is equal to 1, so it's replaced with: if ((flags_ & PoolFlag_PanicOnOverflow) != 0) { |
Why
For #582
What
Testing