Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-303 Avoid pointer usage #590

Merged
merged 1 commit into from
Oct 3, 2023
Merged

GH-303 Avoid pointer usage #590

merged 1 commit into from
Oct 3, 2023

Conversation

dshil
Copy link
Member

@dshil dshil commented Oct 3, 2023 •
edited by gavv
Loading

@dshil dshil requested a review from gavv October 3, 2023 10:13
@dshil dshil added the ready for review Pull request can be reviewed label Oct 3, 2023
@gavv
Copy link
Member

gavv commented Oct 3, 2023 •
edited
Loading

Actually we can make dst_writer_ field a reference and remove panic and check.

Earlier destination writer was set dynamically, and hence it was a pointer and NULL was allowed.

Later I moved it's to constructor, but forgot to change pointer to reference.

@gavv gavv added needs revision Pull request should be revised by its author and removed ready for review Pull request can be reviewed labels Oct 3, 2023
@dshil dshil changed the title GH-303 Writer must exist while writing a packet GH-303 Avoid pointer usage Oct 3, 2023
@dshil dshil added ready for review Pull request can be reviewed and removed needs revision Pull request should be revised by its author labels Oct 3, 2023
@gavv gavv merged commit 1f4884f into roc-streaming:develop Oct 3, 2023
31 checks passed
@gavv gavv removed the ready for review Pull request can be reviewed label Oct 3, 2023
@dshil dshil deleted the dshil/303-check-writer branch October 4, 2023 06:31
@gavv gavv added this to the 0.3.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavv gavv Awaiting requested review from gavv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dshil @gavv