Refactor arena & pool guards and logs #700
Conversation
|
🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats. |
- Instead of more generic "flags" enum, use more specific "guards", so that it's easier to understand the purpose - Use separate flag for each type of guard - Extract method that increments failure counter and checks if panics are enabled for a guard - Use same logging format as in MemoryLimiter
| //! Default memory pool guards. | ||
| enum { | ||
| SlabPool_DefaultGuards = | ||
| (SlabPool_LeakGuard | SlabPool_OverflowGuard | SlabPool_OwnershipGuard) |
There was a problem hiding this comment.
With HeapArena, we don't want leak guard being the default, but, over here, we're ok with that?
There was a problem hiding this comment.
Yes,
We would enable it for heap arena too, but when roc is used from a C library, some allocation & deallocation requests come from the user. We don't want to crash user's app if user decides not to free some resources upon exit, for example. So leak detection is disabled by default and is enabled explicitly in tools and tests.
All requests to pool, on the other hand, are controlled only by us, so we can place stricter defaults.
|
Thanks for review! |
Instead of more generic "flags" enum, use more specific "guards", so that it's easier to understand the purpose
Use separate flag for each type of guard
Extract method that increments failure counter and checks if panics are enabled for a guard
Use same logging format as in MemoryLimiter