Fix GNU/Hurd build #709
Merged
Fix GNU/Hurd build #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like on other platforms, GNU/Hurd needs _POSIX_C_SOURCE to be defined to
get access to get strerror_r declared, otherwise we get:
src/internal_modules/roc_core/target_posix/roc_core/errno_to_str.cpp: In member function 'void roc::core::errno_to_str::format_(int)':
src/internal_modules/roc_core/target_posix/roc_core/errno_to_str.cpp:30:9: error: 'strerror_r' was not declared in this scope; did you mean 'strerror'?
30 | if (strerror_r(err, buffer_, sizeof(buffer_)) != 0) {
| ^~~~~~~~~~
| strerror
They work exactly like on Linux since the toolchain is the same.
GNU/Hurd does not define any hardcoded PATH_MAX limitation, so roc_core has to define its own for its dir_ and file_ statically-allocated arrays.
|
🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats. |
gavv
added
ready for review
|
Thanks! It's always cool to see support for more platforms. I've pushed two follow-up commits:
Please let me know if my update still works on Hurd, since I don't have one to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.