Added fast_random_gaussian() #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats. |
gavv
reviewed
May 7, 2024
Comment on lines
73
to
74
| double u1 = (double)roc::core::fast_random() / (double)UINT32_MAX; | ||
| double u2 = (double)roc::core::fast_random() / (double)UINT32_MAX; |
There was a problem hiding this comment.
nit:
Suggested change
| double u1 = (double)roc::core::fast_random() / (double)UINT32_MAX; | |
| double u2 = (double)roc::core::fast_random() / (double)UINT32_MAX; | |
| double u1 = (double)fast_random() / (double)UINT32_MAX; | |
| double u2 = (double)fast_random() / (double)UINT32_MAX; |
gavv
added
needs revision
|
One small comment. |
gavv
force-pushed
the
feature/guassian_fast_random
branch
from
63312c9
to
e8ea73f
Compare
github-actions
bot
removed
the
needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was required for tests in #688